Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales README.md #148

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Update locales README.md #148

merged 1 commit into from
Mar 28, 2019

Conversation

workgena
Copy link
Contributor

Fix broken link

@ddnexus actually I'm not sure if whole description is "UpToDate".

@workgena workgena changed the title Update lib/locales/README.md WIP: Update lib/locales/README.md Mar 28, 2019
@@ -6,10 +6,10 @@ If you are using pagy with some language missing from the dictionary files, plea

The `pagy.info.single_page`, `pagy.info.item_name` and `pagy.items` keys of the yaml file are pluralized according to the plural rules of the language.

If you are going to submit a dictionary, please check wether the pluralization type of your language exists in the [plurals.rb](https://github.com/ddnexus/pagy/blob/master/lib/locales/plurals.rb) file. If it is missing, please, report it. Thanks.
If you are going to submit a dictionary, please check wether the pluralization type of your language exists in the [lib/locales/utils/p11n.rb](utils/p11n.rb) file. If it is missing, please, report it. Thanks.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using relative links in such cases.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thank you!

@workgena workgena changed the title WIP: Update lib/locales/README.md Update lib/locales/README.md Mar 28, 2019
@workgena workgena changed the title Update lib/locales/README.md Update locales README.md Mar 28, 2019
@ddnexus ddnexus merged commit 310c804 into ddnexus:master Mar 28, 2019
@ddnexus ddnexus added the merged label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants