Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style cleanup #24

Closed
wants to merge 1 commit into from
Closed

style cleanup #24

wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented May 29, 2018

  • uppercase instance vars are uncommon, so avoiding that
  • using readable argument names (also helps with code autocomplete for end-users)

@ddnexus

@ddnexus
Copy link
Owner

ddnexus commented May 29, 2018

Thank you. Will merge in 0.8.0 (see dev branch)

@gamafranco
Copy link
Contributor

❤️

@ddnexus ddnexus changed the base branch from master to dev May 29, 2018 10:26
@ddnexus ddnexus added the WIP label May 29, 2018
ddnexus pushed a commit that referenced this pull request May 29, 2018
@grosser @ddnexus
style cleanup (#24)
2f5b532
@ddnexus
Copy link
Owner

ddnexus commented May 29, 2018

merged

@ddnexus ddnexus closed this May 29, 2018
@ddnexus ddnexus removed the WIP label May 29, 2018
ddnexus pushed a commit that referenced this pull request May 29, 2018
@grosser @ddnexus
style cleanup (#24)
9b0d420
@ddnexus ddnexus added the merged label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grosser @ddnexus @gamafranco