Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Meilisearch extra #318

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Conversation

molfar
Copy link
Contributor

@molfar molfar commented Jun 23, 2021

This PR fixes response format from Meilisearch mock object to match original one.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #318 (b48c8f6) into dev (755c9f1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1837      1837           
=========================================
  Hits          1837      1837           
Impacted Files Coverage Δ
lib/pagy/extras/meilisearch.rb 100.00% <100.00%> (ø)
test/mock_helpers/meilisearch.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755c9f1...b48c8f6. Read the comment docs.

@ddnexus ddnexus merged commit ec748c2 into ddnexus:dev Jun 24, 2021
@ddnexus
Copy link
Owner

ddnexus commented Jun 24, 2021

That's the problem with mock classes :)
Thank you.

@ddnexus ddnexus added the merged label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants