Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulma extra #62

Merged
merged 6 commits into from
Jul 7, 2018
Merged

Bulma extra #62

merged 6 commits into from
Jul 7, 2018

Conversation

enzinia
Copy link
Contributor

@enzinia enzinia commented Jul 6, 2018

According to #56.

Added extra for Bulma CSS Framework.

All templates and helper was tested on real Bulma project.

@ddnexus
Copy link
Owner

ddnexus commented Jul 6, 2018

@enzinia Amazing job! Thank you!

Would you be interested in adding also a pagy_nav_compact_bulma and pagy_nav_reponsive_bulma helpers taken from the bootstrap version, but with the proper classes replaced?

@enzinia
Copy link
Contributor Author

enzinia commented Jul 6, 2018

@ddnexus sure, it can be useful.

What about to add it in separated PR?

@ddnexus
Copy link
Owner

ddnexus commented Jul 6, 2018

it is actually all about bulma, so better here. Thanks.

@enzinia
Copy link
Contributor Author

enzinia commented Jul 7, 2018

Here we go, added bulma helpers for compact and responsive extras.

Compact one was a little tricky, but I managed to do this in Bulma way.

There is how it looks:
bulma_compact

Please tell me, if I need to squash commits.

@ddnexus ddnexus changed the base branch from master to dev July 7, 2018 14:21
@ddnexus ddnexus merged commit 8e6ac3e into ddnexus:dev Jul 7, 2018
@ddnexus
Copy link
Owner

ddnexus commented Jul 7, 2018

Great job. Thank you!

ddnexus added a commit that referenced this pull request Jul 8, 2018
@ddnexus
Copy link
Owner

ddnexus commented Jul 8, 2018

@enzinia
Hi I fixed quite a few typos in the PR ("area" used in place of "aria" in helpers and tests), then I refactored the pagy_nav_bulma as a single method, since the private method was not called by any other methods.

Then I refactored also the responsive helpers so they can all be more consistent across implementations.

Please, could you test the final result in the dev branch? If everything will be ok, I will merge it in master and push to rubygems. Thanksd

@enzinia
Copy link
Contributor Author

enzinia commented Jul 9, 2018

@ddnexus
Oh, so sorry for this ridiculous typos. Please fix it also in templates.

Rechecked all Bulma helpers and templates (just in case) from dev branch. All looks good to me, doesn't see any problems.

Also can confirm that Turbolinks issue fixed, there is no errors now.

ddnexus added a commit that referenced this pull request Jul 9, 2018
ddnexus pushed a commit that referenced this pull request Jul 9, 2018
* Added Bulma extra helper
* Added templates for Bulma extra
* Added documentation for Bulma extra
* Added Bulma support for responsive extra
* Added Bulma support for compact extra
* Added information about bulma extra into README
ddnexus added a commit that referenced this pull request Jul 9, 2018
@ddnexus
Copy link
Owner

ddnexus commented Jul 9, 2018

I totally missed to check the templates. Fixed. Thanks.

@ddnexus ddnexus added the merged label Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants