Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added color:black style in bootstrap compact input. #83

Closed

Conversation

Tolchi
Copy link
Contributor

@Tolchi Tolchi commented Sep 18, 2018

Can't read current page in bootstrap compact navigation due to its color.
Added color: black; in its style.

@ddnexus
Copy link
Owner

ddnexus commented Sep 19, 2018

Hi @Tolchi,
could you post a screenshot?

@Tolchi
Copy link
Contributor Author

Tolchi commented Sep 21, 2018

Hi @Tolchi,
could you post a screenshot?

Here we go:
Before patch:
before
After patch:
after
;)

@ddnexus
Copy link
Owner

ddnexus commented Sep 21, 2018

I don't have the same problem, and since nobody before you raised that issue, I think it is probably due to the CSS rules in your own page OR in the browser you are using. Did you try with other browsers and in a basic app without any CSS customization?

The style that is added to the elements in the helpers and templates tries to be minimal and independent from colors that should belong to the page style, not to the item style.

Is there any reason - that I may be missing - that makes this PR necessary in some context (and would be unharmful to the others)?

@serghost
Copy link
Contributor

serghost commented Sep 21, 2018

I have the same issue with bootstrap 3.
screen shot 2018-09-21 at 12 57 08

It's because the input field inherits its color from the btn-primary class (which is #fff)

However bootstrap 4 doesn't have this issue

@ddnexus
Copy link
Owner

ddnexus commented Sep 21, 2018

@serghost thank you for the explanation. It makes sense now. We should search a way to avoid the hard-coding of a specific color in the element style. Any idea?

@ddnexus
Copy link
Owner

ddnexus commented Sep 22, 2018

Implemented in a different way (see #86)

@ddnexus ddnexus closed this Sep 22, 2018
@Tolchi Tolchi deleted the bootstrap-compact-input-color-fix branch September 22, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants