Strict type all non-test code #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 240 240
=========================================
Hits 240 240 Continue to review full report at Codecov.
|
KaanOzkan
approved these changes
Jan 5, 2021
lib/yard-sorbet/sig_handler.rb
Outdated
| abstract: false, | ||
| params: {}, | ||
| return: nil | ||
| } | ||
| parsed[:abstract] = false | ||
| parsed[:params] = {} |
There was a problem hiding this comment.
Now that they are part of the declaration we can remove these 2 lines
parsed[:abstract] = false
parsed[:params] = {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades all non-spec code to
typed: strict. Runtime checks are performed only in tests, to minimize performance impact.I had to update the
sorbet/dir to pick up asorbet-typedchange so sorbet would permit a call toYARD::CodeObjects::ClassObject.new. Sorry for the noise introduced to the diff, but it's isolated to a single commit. (I could also extract to a separate PR if you'd like.)