Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top_const_ref parsing #63

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix top_const_ref parsing #63

merged 1 commit into from
Jun 14, 2021

Conversation

dduugg
Copy link
Owner

@dduugg dduugg commented Jun 14, 2021

Previously, top_const_ref nodes, e.g. ::Foo, would have the leading :: removed.

This can be seen at https://rubydoc.brew.sh/OS/Mac.html#latest_sdk_version-class_method
The return type links to https://rubydoc.brew.sh/OS/Mac/Version.html, rather than https://rubydoc.brew.sh/Version.html

(This PR also includes misc. cleanup in the sig parser)

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #63 (562ed81) into master (4620a0b) will decrease coverage by 0.49%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   99.31%   98.82%   -0.50%     
==========================================
  Files          16       16              
  Lines         588      595       +7     
==========================================
+ Hits          584      588       +4     
- Misses          4        7       +3     
Impacted Files Coverage Δ
lib/yard-sorbet/sig_to_yard.rb 90.90% <90.90%> (-3.38%) ⬇️
spec/yard_sorbet/handlers/sig_handler_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4620a0b...562ed81. Read the comment docs.

@dduugg dduugg merged commit d799448 into master Jun 14, 2021
@dduugg dduugg deleted the sig-to-yard-cleanup branch June 14, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant