Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add User's lecture API #14

Merged
merged 10 commits into from
Oct 29, 2022
Merged

feat: Add User's lecture API #14

merged 10 commits into from
Oct 29, 2022

Conversation

namgus
Copy link
Member

@namgus namgus commented Oct 28, 2022

Things to be changed

  • Read User’s Lecture List API 추가
  • Update User’s Lecture List API 추가
  • Get All Lectures API 추가

@namgus namgus self-assigned this Oct 28, 2022
@namgus namgus added the enhancement New feature or request label Oct 28, 2022
cosmoquester
cosmoquester requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@cosmoquester cosmoquester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳! 👍 코멘트 몇 개만 확인해주세요!

src/main/java/com/de_alone/dokkang/security/WebSecurityConfig.java Outdated Show resolved Hide resolved
@cosmoquester
Copy link
Member

말고는 api들 전부 정상동작 확인했습니다!

namgus and others added 4 commits October 29, 2022 02:49
@namgus @cosmoquester
fix: Change word to fit API spec
b029c2d 
Co-authored-by: ParkSangJun <30718444+cosmoquester@users.noreply.github.com>
@namgus @cosmoquester
fix: Modify duplicated func name
47eaa7d 
Co-authored-by: ParkSangJun <30718444+cosmoquester@users.noreply.github.com>
@namgus
fix: Change lecture_id to fit API spec
e2c61e2
@namgus
fix: Remove path for authorization
2ccf2a9
@namgus namgus requested a review from cosmoquester October 28, 2022 18:36
cosmoquester
cosmoquester approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@cosmoquester cosmoquester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lim-it-err lim-it-err merged commit 6fe65c3 into master Oct 29, 2022
@lim-it-err lim-it-err deleted the namgu/my-page branch October 29, 2022 09:24
lim-it-err added a commit that referenced this pull request Oct 29, 2022
@lim-it-err
Revert "feat: Add User's lecture API (#14)"
ba9d5a4 
This reverts commit 6fe65c3.
@lim-it-err lim-it-err mentioned this pull request Oct 29, 2022
Closed
@lim-it-err lim-it-err restored the namgu/my-page branch October 29, 2022 09:26
@cosmoquester cosmoquester deleted the namgu/my-page branch October 29, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmoquester cosmoquester cosmoquester approved these changes

@lim-it-err lim-it-err Awaiting requested review from lim-it-err

@NikkiDilling NikkiDilling Awaiting requested review from NikkiDilling

Assignees

@namgus namgus

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namgus @cosmoquester @lim-it-err