Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: detail and test #18

Merged
merged 8 commits into from
Nov 9, 2022
Merged

test: detail and test #18

merged 8 commits into from
Nov 9, 2022

Conversation

lim-it-err
Copy link
Contributor

Added Test of Main Code.

@lim-it-err lim-it-err closed this Nov 9, 2022
@lim-it-err
Copy link
Contributor Author

Error found on Test.

@lim-it-err
Copy link
Contributor Author

+)Test가 Authorization이 필요하여 Dependency를 수정했습니다.
+)테스트 코드 작성하였습니다
+) 데이터베이스 수정한 부분은 기존 master 코드에 호환되도록 다시 수정한 것입니다.
검토 부탁드립니다!!

@lim-it-err lim-it-err reopened this Nov 9, 2022
@cosmoquester
Copy link
Member

get method를 body랑 쓰는 게 http 프로토콜 상 맞지 않아서 그것만 path variable로 수정했습니다! 👍

@cosmoquester cosmoquester merged commit 9c61d27 into master Nov 9, 2022
@cosmoquester cosmoquester deleted the jeonghan/detail_and_test branch November 9, 2022 13:20
@namgus namgus changed the title Jeonghan/detail and test test: detail and test Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmoquester cosmoquester cosmoquester approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lim-it-err @cosmoquester