Occasional timeouts on readADC() #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasional Timeouts were detected when running on a ESP8266.
- See https://www.circuitsonline.net/forum/view/167087
Problem is due to timeout settings in readADC(). These leave very little margin.
- The yield() may trigger a task switch on an ESP and processing may be suspended for several milliseconds.
- Fixed by allowing a 10 millisecond margin on timeouts
Also fixed by postponing the yield() until after the timeout check
- This way the system performs at least one other round
before going into timeout.
- This is still not 100% fail-safe as the OS may allow for interrupts and task-switches outside of the yield function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasional Timeouts were detected when running on a ESP8266.
- See https://www.circuitsonline.net/forum/view/167087
Problem is due to timeout settings in readADC(). These leave very little margin.
Also fixed by postponing the yield() until after the timeout check
- This way the system performs at least one other round before going into timeout. - This is still not 100% fail-safe as the OS may allow for interrupts and task-switches outside of the yield function