Switch to pico-args #116
Merged
Switch to pico-args #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
force-pushed
the
pico-args
branch
4 times, most recently
from
9cce597 to
51f48e6
Compare
|
I think I should add some more tests before merging this. |
This was referenced Nov 24, 2020
jyn514
force-pushed
the
pico-args
branch
2 times, most recently
from
a3cef1c to
fb6705b
Compare
This caught a bug! Parse errors should be printed to stderr, not stdout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changelog for everything this changes.
RazrFalcon/pico-args#25 would have made this a lot easier.
Closes #115. Fixes #111. Fixes #89.
This will unfortunately be a breaking change specifically because of the change toI'm going to make this change in a follow-up to avoid having to release a new major version: #117walk_dir. In practice I doubt anyone was using it, but better safe than sorry.