Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #150

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix CI #150

merged 1 commit into from
Aug 30, 2021

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Aug 30, 2021

  • Fix clippy warnings

  • Fix MSRV task to use latest stable to install cargo-sweep

    Before, it would use the lower version to install, which broke when cargo-sweep updated its own MSRV.

  • Fix tests not to conflict with one another

They were using the same target directory, which caused them to fail for some reason.
I expect this is related to rust-lang/cargo#8640 somehow but it doesn't seem worth investigating.

- Fix clippy warnings
- Fix MSRV task to use latest stable to install `cargo-sweep`

  Before, it would use the lower version to install, which broke when cargo-sweep updated its own MSRV.

- Fix tests not to conflict with one another

  They were using the same target directory, which caused them to fail for some reason.
  I expect this is related to rust-lang/cargo#8640 somehow but it doesn't seem worth investigating.
@jyn514 jyn514 merged commit b5fc374 into master Aug 30, 2021
@jyn514 jyn514 deleted the warnings branch August 30, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant