-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Action usable inside a Docker container #121
Conversation
this is not intended to be used inside a container -- you're free to maintain your fork which does though! |
strange position since using docker images in GHA is quite popular |
I'm not going to hack around a bug in github for something I don't intend to support and has a bunch of complexity and problem surface area |
For anyone doing a web search for the error message, it is |
Hi,
We are using this action to install Python on ARM machines and the workflow steps are executed inside a container (almost bare
ubuntu:20.04
).There is a known problem with
github.action_path
- it is incorrectly set if the action is executed inside a container: 1, 2. We have encountered it ourselves when trying to use the action. It failed with:The proposed fix is to check if the
install_python
script exists under either of the two paths:${{ github.action_path }}/bin/
- for the outside container scenario$GITHUB_ACTION_PATH/bin/
- for the inside container scenarioI've added the matrix entry with a Docker image to check if this would work: it works.