-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build from source #71
Build from source #71
Conversation
The resulting files will be placed in ./tmp, e.g. ls -l tmp/ total 992 -rw-r--r-- 1 gerhard staff 12548 20 Feb 18:02 accept-0.3.4.ez -rw-r--r-- 1 gerhard staff 211232 20 Feb 18:02 prometheus-4.2.2.ez -rw-r--r-- 1 gerhard staff 14053 20 Feb 18:02 prometheus_cowboy-0.1.7.ez -rw-r--r-- 1 gerhard staff 21638 20 Feb 18:02 prometheus_httpd-2.1.10.ez -rw-r--r-- 1 gerhard staff 10708 20 Feb 18:02 prometheus_process_collector-1.4.0.ez -rw-r--r-- 1 gerhard staff 223943 20 Feb 18:02 prometheus_rabbitmq_exporter-3.7.20190220.ez I've changed the version of this plugin to use the date for the patch part, feel free to change back if you disagree. Notice that I've deleted the prometheus_rabbitmq_exporter.app.src, this is now generated by erlang.mk and dropped in ebin/prometheus_rabbitmq_exporter.app - does it look correct @deadtrickster? Want to integrate with Docker & testing before merging. This started as #63, see the discussion for more context.
This is what happens when I use `./rebar3 archive` instead of zip. Let me know if you can figure it out @deadtrickster - I'm happy to stick with zip.
This reverts commit 72ad2f2.
cc @dcorbacho |
We prefer it if rebar3 is not committed to repos. |
I'm ok with the date, wondering why, though. Does patched rebar3 archive work for you? |
Thanks @tsloughter! You might want to check the following repos for rebar3: * https://github.com/deadtrickster/accept * https://github.com/deadtrickster/prometheus.erl * https://github.com/deadtrickster/prometheus-cowboy * https://github.com/deadtrickster/prometheus_process_collector
The last release, Maybe @michaelklishin can suggest a better versioning schema. @dumbbell might also be able to help.
No, it doesn't. 72ad2f2 uses |
Hmm, I explained that in the README and issues, guess not clear, but - it works up to most recent. Really simple. I just realized you tried to use rebar to build the plugin. Never tried that yet. |
The resulting Docker images are only tagged with the RabbitMQ minor version, since prometheus_rabbitmq_exporter is expected to work with the latest stable RabbitMQ, regardless which that is at time of building. When these images are built, since we are using the `--pull` flag, we will always get the latest FROM image version at time of building. Without any automation, manually updating this version to the latest upstream feels inefficient and quiet boring - that would explain the version gaps in https://hub.docker.com/r/deadtrickster/rabbitmq_prometheus/tags, so I'm thinking to not use the exact RabbitMQ version in the tag for this image. I am on-board with using the PROJECT_VERSION (e.g. 3.7.2.4) if you think that is better @deadtrickster. Deleted the pure variant, it's just a duplicate of Dockerfile since #54, prometheus_process_collector ends up in both image variants.
@deadtrickster this is now ready for you. I've tested both
|
Thanks, that's amazing. do you think
is a good candidate for Travis/Circle? |
hmm, ln -h is bsd specific? |
I almost added a make target that runs an acceptance test on both containers, but then didn't want to extend the PR too far. Yes, adding it to your CI of choice is a great idea. I would use curl's
Yes, it is.
|
so the sequence is |
Single command, multiple targets: |
Will try on the Linux workstation later on today and add a few improvements. I've only made it work. Will make it right next & eventually make it fast 😉 |
This should be easy to reproduce and guaranteed to work:
Based on the above, to build all ezs on a Linux system with Erlang 21.2 & Elixir 1.8 installed (wget & zip are also required), all ezs can be built with a single command: I've tested the ezs produced:
|
I added |
Add
make ezs
so that we can build .ez files for all deps & plugin with a single command.The resulting files will be placed in
./tmp
:I've changed the version of this plugin to use the date for the patch part, feel free to change back if you disagree.
Notice that I've deleted the
prometheus_rabbitmq_exporter.app.src
, this is now generated by erlang.mk and dropped inebin/prometheus_rabbitmq_exporter.app
- does it look correct @deadtrickster?Want to integrate with Docker & testing before merging.
This started as #63, see the discussion for more context.