Add string extension IsHtmlFile #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all the minification to an extension to StreamReader - Get rid of global var _features - Extend the Features class with a constructor and add MaxLength
|
Great stuff - thanks for this! |
|
I'm glad you like it... Looking at the way we retrieve the files, I think is a bit too complex we https://msdn.microsoft.com/en-us/library/ms143316(v=vs.110).aspx But that is just a thought I did not research any of it On Tue, Apr 19, 2016 at 12:11 PM, Dean notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address bug #25