Skip to content

Commit

Permalink
lateral limits: remove Subaru exception (commaai#32244)
Browse files Browse the repository at this point in the history
* remove exception

* update Outback params

* clean up

* adjust to the upper limit

* don't change control, only docs

* rough
  • Loading branch information
sshane authored Apr 18, 2024
1 parent f2ee3f0 commit 692a21e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
10 changes: 0 additions & 10 deletions selfdrive/car/tests/test_lateral_limits.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from openpilot.selfdrive.car.car_helpers import interfaces
from openpilot.selfdrive.car.fingerprints import all_known_cars
from openpilot.selfdrive.car.interfaces import get_torque_params
from openpilot.selfdrive.car.subaru.values import CAR as SUBARU

CAR_MODELS = all_known_cars()

Expand All @@ -22,12 +21,6 @@
# jerk is measured over half a second
JERK_MEAS_T = 0.5

# TODO: put these cars within limits
ABOVE_LIMITS_CARS = [
SUBARU.SUBARU_LEGACY,
SUBARU.SUBARU_OUTBACK,
]

car_model_jerks: defaultdict[str, dict[str, float]] = defaultdict(dict)


Expand All @@ -50,9 +43,6 @@ def setUpClass(cls):
if CP.notCar:
raise unittest.SkipTest

if CP.carFingerprint in ABOVE_LIMITS_CARS:
raise unittest.SkipTest

CarControllerParams = importlib.import_module(f'selfdrive.car.{CP.carName}.values').CarControllerParams
cls.control_params = CarControllerParams(CP)
cls.torque_params = get_torque_params(cls.car_model)
Expand Down
2 changes: 1 addition & 1 deletion selfdrive/car/torque_data/override.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ legend = ["LAT_ACCEL_FACTOR", "MAX_LAT_ACCEL_MEASURED", "FRICTION"]
# Totally new cars
"RAM_1500_5TH_GEN" = [2.0, 2.0, 0.05]
"RAM_HD_5TH_GEN" = [1.4, 1.4, 0.05]
"SUBARU_OUTBACK" = [2.0, 2.0, 0.2]
"SUBARU_OUTBACK" = [2.0, 1.5, 0.2]
"CADILLAC_ESCALADE" = [1.899999976158142, 1.842270016670227, 0.1120000034570694]
"CADILLAC_ESCALADE_ESV_2019" = [1.15, 1.3, 0.2]
"CHEVROLET_BOLT_EUV" = [2.0, 2.0, 0.05]
Expand Down

0 comments on commit 692a21e

Please sign in to comment.