Hyundai: remove outdated eps FW (commaai#32020)

* rm from ed882557605319f9 * rm from 310cf131d28b30d8 * rm from e6dd11f4969e1f74 * rm from 145908dabb729ad9 * rm from b938870bef07f799 * rm from b0af2fff166d80fe * unknown about these, but safe to do this * rm from 077309a26bf98013 * rm from 01d4ba35f8288743 * rm from b5374bdeea21f5ce * rm from 979eb0f6c3682a58 * rm from eb5a50f9e98f50b9 * rm from 786fc028c014be71 * rm from 3f77febac29e35d5 * these also unknown, but should be safe * format! * test all ecus
deanlee · Mar 27, 2024 · ae6761f · ae6761f
1 parent 6b710a5
commit ae6761f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 21 deletions.
diff --git a/selfdrive/car/hyundai/fingerprints.py b/selfdrive/car/hyundai/fingerprints.py
@@ -194,21 +194,17 @@
  (Ecu.eps, 0x7d4, None): [
  b'\xf1\x00DN8 MDPS C 1,00 1,01 56310L0010\x00 4DNAC101',
  b'\xf1\x00DN8 MDPS C 1.00 1.01 56310-L0010 4DNAC101',
+ b'\xf1\x00DN8 MDPS C 1.00 1.01 56310-L0210 4DNAC101',
  b'\xf1\x00DN8 MDPS C 1.00 1.01 56310-L0210 4DNAC102',
  b'\xf1\x00DN8 MDPS C 1.00 1.01 56310L0010\x00 4DNAC101',
  b'\xf1\x00DN8 MDPS C 1.00 1.01 56310L0200\x00 4DNAC102',
+ b'\xf1\x00DN8 MDPS C 1.00 1.01 56310L0210\x00 4DNAC101',
  b'\xf1\x00DN8 MDPS C 1.00 1.01 56310L0210\x00 4DNAC102',
+ b'\xf1\x00DN8 MDPS C 1.00 1.03 56310-L1010 4DNDC103',
+ b'\xf1\x00DN8 MDPS C 1.00 1.03 56310-L1030 4DNDC103',
  b'\xf1\x00DN8 MDPS R 1.00 1.00 57700-L0000 4DNAP100',
  b'\xf1\x00DN8 MDPS R 1.00 1.00 57700-L0000 4DNAP101',
  b'\xf1\x00DN8 MDPS R 1.00 1.02 57700-L1000 4DNDP105',
- b'\xf1\x8756310-L0010\xf1\x00DN8 MDPS C 1.00 1.01 56310-L0010 4DNAC101',
- b'\xf1\x8756310-L0210\xf1\x00DN8 MDPS C 1.00 1.01 56310-L0210 4DNAC101',
- b'\xf1\x8756310-L1010\xf1\x00DN8 MDPS C 1.00 1.03 56310-L1010 4DNDC103',
- b'\xf1\x8756310-L1030\xf1\x00DN8 MDPS C 1.00 1.03 56310-L1030 4DNDC103',
- b'\xf1\x8756310L0010\x00\xf1\x00DN8 MDPS C 1,00 1,01 56310L0010\x00 4DNAC101',
- b'\xf1\x8756310L0010\x00\xf1\x00DN8 MDPS C 1.00 1.01 56310L0010\x00 4DNAC101',
- b'\xf1\x8756310L0210\x00\xf1\x00DN8 MDPS C 1.00 1.01 56310L0210\x00 4DNAC101',
- b'\xf1\x8757700-L0000\xf1\x00DN8 MDPS R 1.00 1.00 57700-L0000 4DNAP100',
  ],
  (Ecu.fwdCamera, 0x7c4, None): [
  b'\xf1\x00DN8 MFC AT KOR LHD 1.00 1.02 99211-L1000 190422',
@@ -564,12 +560,11 @@
  b'\xf1\x00DL3_ SCC FHCUP 1.00 1.04 99110-L2100 ',
  ],
  (Ecu.eps, 0x7d4, None): [
+ b'\xf1\x00DL3 MDPS C 1.00 1.01 56310-L3110 4DLAC101',
  b'\xf1\x00DL3 MDPS C 1.00 1.01 56310-L3220 4DLAC101',
  b'\xf1\x00DL3 MDPS C 1.00 1.02 56310-L2220 4DLDC102',
  b'\xf1\x00DL3 MDPS C 1.00 1.02 56310L3220\x00 4DLAC102',
- b'\xf1\x8756310-L3110\xf1\x00DL3 MDPS C 1.00 1.01 56310-L3110 4DLAC101',
- b'\xf1\x8756310-L3220\xf1\x00DL3 MDPS C 1.00 1.01 56310-L3220 4DLAC101',
- b'\xf1\x8757700-L3000\xf1\x00DL3 MDPS R 1.00 1.02 57700-L3000 4DLAP102',
+ b'\xf1\x00DL3 MDPS R 1.00 1.02 57700-L3000 4DLAP102',
  ],
  (Ecu.fwdCamera, 0x7c4, None): [
  b'\xf1\x00DL3 MFC AT KOR LHD 1.00 1.04 99210-L2000 210527',
@@ -866,10 +861,10 @@
  b'\xf1\x00CNhe SCC FHCUP 1.00 1.01 99110-BY000 ',
  ],
  (Ecu.eps, 0x7d4, None): [
+ b'\xf1\x00CN7 MDPS C 1.00 1.02 56310/BY050 4CNHC102',
+ b'\xf1\x00CN7 MDPS C 1.00 1.03 56310/BY050 4CNHC103',
  b'\xf1\x00CN7 MDPS C 1.00 1.03 56310BY0500 4CNHC103',
  b'\xf1\x00CN7 MDPS C 1.00 1.04 56310BY050\x00 4CNHC104',
- b'\xf1\x8756310/BY050\xf1\x00CN7 MDPS C 1.00 1.02 56310/BY050 4CNHC102',
- b'\xf1\x8756310/BY050\xf1\x00CN7 MDPS C 1.00 1.03 56310/BY050 4CNHC103',
  ],
  },
  CAR.HYUNDAI_KONA_HEV: {
@@ -894,11 +889,10 @@
  ],
  (Ecu.eps, 0x7d4, None): [
  b'\xf1\x00DN8 MDPS C 1.00 1.01 56310-L5000 4DNHC101',
+ b'\xf1\x00DN8 MDPS C 1.00 1.02 56310-L5450 4DNHC102',
+ b'\xf1\x00DN8 MDPS C 1.00 1.02 56310-L5500 4DNHC102',
+ b'\xf1\x00DN8 MDPS C 1.00 1.03 56310-L5450 4DNHC103',
  b'\xf1\x00DN8 MDPS C 1.00 1.03 56310L5450\x00 4DNHC104',
- b'\xf1\x8756310-L5450\xf1\x00DN8 MDPS C 1.00 1.02 56310-L5450 4DNHC102',
- b'\xf1\x8756310-L5450\xf1\x00DN8 MDPS C 1.00 1.03 56310-L5450 4DNHC103',
- b'\xf1\x8756310-L5500\xf1\x00DN8 MDPS C 1.00 1.02 56310-L5500 4DNHC102',
- b'\xf1\x8756310L5450\x00\xf1\x00DN8 MDPS C 1.00 1.03 56310L5450\x00 4DNHC104',
  ],
  (Ecu.fwdCamera, 0x7c4, None): [
  b'\xf1\x00DN8HMFC AT KOR LHD 1.00 1.03 99211-L1000 190705',

diff --git a/selfdrive/car/hyundai/tests/test_hyundai.py b/selfdrive/car/hyundai/tests/test_hyundai.py
@@ -85,10 +85,8 @@ def test_correct_ecu_response_database(self):
  for car_model, ecus in FW_VERSIONS.items():
  with self.subTest(car_model=car_model.value):
  for ecu, fws in ecus.items():
- # TODO: enable for Ecu.eps
- if ecu[0] in (Ecu.fwdCamera, Ecu.fwdRadar, Ecu.abs):
- self.assertTrue(all(fw.startswith(expected_fw_prefix) for fw in fws),
- f"FW from unexpected request in database: {(ecu, fws)}")
+ self.assertTrue(all(fw.startswith(expected_fw_prefix) for fw in fws),
+ f"FW from unexpected request in database: {(ecu, fws)}")
 
  @settings(max_examples=100)
  @given(data=st.data())