Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow combining of batches to support multiple sources of records (CI… #472

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

georgehelman
Copy link
Contributor

…PRS and Portal)

dear_petition/petition/api/viewsets.py Show resolved Hide resolved
src/features/ExistingPetitions.jsx Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
dear_petition/petition/etl/tests/test_transform.py Outdated Show resolved Hide resolved
dear_petition/petition/etl/tests/test_transform.py Outdated Show resolved Hide resolved
dear_petition/petition/etl/tests/test_transform.py Outdated Show resolved Hide resolved
dear_petition/petition/etl/transform.py Show resolved Hide resolved
Copy link
Contributor

@rebecca-draben rebecca-draben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgehelman georgehelman merged commit ca1d367 into master Apr 30, 2024
1 check passed
@georgehelman georgehelman deleted the combine_batches branch April 30, 2024 21:27
@@ -71,7 +186,7 @@ export const ExistingPetitions = () => {
<TableCell header />
</TableHeader>
<TableBody>
{data?.results?.map((batch) => (
{data.results?.map((batch) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line might introduce a bug when the getuserBatches query is still loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants