Take all updates that we can #1894
Conversation
|
Looks like maybe the |
|
Ugh yeah, I noticed this in #1876 and wasn't sure why I didn't notice it locally, but I think I didn't mash my way through enough of the install/lint/test commands because I'm seeing it now. I'll poke around a bit. |
|
Looks like this is an incompatibility between TypeScript and typescript-eslint. (You can see a reference to it here: https://github.com/typescript-eslint/typescript-eslint/pull/7968/files#r1399942500). It'll probably get fixed in the latest release of typescript-eslint, but we can't pick that up due to Node v14 incompatibilities. So we can work around it by skipping validation of the type declarations used in the eslint plugin with the |
ebroder
force-pushed
the
evan/updates
branch
from
218c4d8 to
6e0f0e3
Compare
Was the force-push after this comment supposed to include the change you described (adding |
The latest versions of mediasoup use the `??=` operator, which isn't supported on Node 14, so we need to block dependabot updates. Additionally, our block on `@types/node` didn't allow us to take updates to the v14 types, so relax that slightly. Additionally, drop `p-throttle` as a dependency, as we have not used it since c2d07b3. Enable `skipLibCheck` on our eslint plugin - this causes tsc to typecheck our plugin code but take library types as accurate. This is necessary because our version of typescript-eslint has some incompatibilities with the latest version of TypeScript, and we can't currently update typescript-eslint due to Node v14 incompatibilities. Finally, some update-related housekeeping: add aria-labels to components in `GuessQueuePage` and `Puzzle` which have tooltips (which aren't typically used as labels by screenreaders). These aren't required with our current version of `eslint-plugin-jsx-a11y`, but it seems like they will likely be required in the future. (The latest verison does require them, although it also has a bug with table elements, so we are deferring that update for now.)
ebroder
force-pushed
the
evan/updates
branch
from
6e0f0e3 to
bfd4bb9
Compare
Ah yes it was, whoops. Should be there now. |
The latest versions of mediasoup use the
??=operator, which isn't supported on Node 14, so we need to block dependabot updates. Additionally, our block on@types/nodedidn't allow us to take updates to the v14 types, so relax that slightly.Additionally, drop
p-throttleas a dependency, as we have not used it since c2d07b3.Finally, some update-related housekeeping: add aria-labels to components in
GuessQueuePageandPuzzlewhich have tooltips (which aren't typically used as labels by screenreaders). These aren't required with our current version ofeslint-plugin-jsx-a11y, but it seems like they will likely be required in the future. (The latest verison does require them, although it also has a bug with table elements, so we are deferring that update for now.)