Improve validation for image uploads. #2394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google App Script insertImage API only appears to support GIF/PNG/JPG images. Attempts to upload other formats (e.g. webp) fail with an internal error. For uploads, indicate that these are the only accepted file extensions. Clients often treat this as a suggestion rather than a hard requirement if someone is particularly certain that a file will work despite the extension being different. For links, make a HEAD request for the image and inspect the Content-Type in the response headers. Fail open in cases where we can't definitively determine the Content-Type. Note that copy-pasting images via the keyboard shortcut works and supports other formats, so this is probably a simpler approach to take in most cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google App Script insertImage API only appears to support GIF/PNG/JPG images. Attempts to upload other formats (e.g. webp) fail with an internal error.
For uploads, indicate that these are the only accepted file extensions. Clients often treat this as a suggestion rather than a hard requirement if someone is particularly certain that a file will work despite the extension being different.
For links, make a HEAD request for the image and inspect the Content-Type in the response headers. Fail open in cases where we can't definitively determine the Content-Type.
Note that copy-pasting images via the keyboard shortcut works and supports other formats, so this is probably a simpler approach to take in most cases.
See #2285