Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-item max pile size limits #2

Open
deathcap opened this issue Jun 15, 2014 · 0 comments
Open

Per-item max pile size limits #2

deathcap opened this issue Jun 15, 2014 · 0 comments
Labels
enhancement

Comments

@deathcap
Copy link
Owner

Currently, ItemPile.maxPileSize (default 64) sets the maximum count (except, Infinity is also allowed) — but setting different limits for the pile based on the item type could also be useful. Some items reasonably should only allow smaller pile sizes.
deathcap added a commit that referenced this issue Jun 15, 2014
@deathcap
Fix increase(Infinity) to now set count=Infinity instead of maxPileSize
a1029c4 
Infinitely-sized piles now can be transferred in inventories as you
would expect, creating another infinitely-sized pile, instead of trying
to fill up the entire inventory with multiple maxPileSize piles.

Closes deathcap/inventory-window#24

This may need to be revisited if only finite pile sizes are desired,
perhaps with per-item-type limits (ref GH-2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deathcap