Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support jd provider #127

Merged
merged 6 commits into from
Apr 17, 2024
Merged

feat: support jd provider #127

merged 6 commits into from
Apr 17, 2024

Conversation

CNLHC
Copy link
Contributor

@CNLHC CNLHC commented Apr 9, 2024

Support JD provider

@CNLHC CNLHC requested review from gaocegege, Triple-Z and a team as code owners April 9, 2024 07:38
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Triple-Z
Triple-Z requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Can you add tests for jd provider under the tests directory and run them by Makefile?

@CNLHC
Copy link
Contributor Author

CNLHC commented Apr 17, 2024

Thanks for your contribution.

Can you add tests for jd provider under the tests directory and run them by Makefile?

sure

Triple-Z
Triple-Z approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please add README and describe how to export bills from JD if you are available.

@CNLHC CNLHC force-pushed the feat/support-jd branch 3 times, most recently from 30131b7 to 82f4cb6 Compare April 17, 2024 08:46
@Triple-Z Triple-Z merged commit d0cf159 into deb-sig:master Apr 17, 2024
2 checks passed
@Triple-Z
Copy link
Member

Thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Triple-Z Triple-Z Triple-Z approved these changes

@gaocegege gaocegege Awaiting requested review from gaocegege gaocegege is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CNLHC @gaocegege @Triple-Z