Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icbc): support icbc debit new bill format #133

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

Triple-Z
Copy link
Member

@Triple-Z Triple-Z commented Sep 18, 2024

  • fix(icbc): don't ignore the first transaction!

Description

support icbc debit card new bill format.

Motivation and Context

icbc debit card has a new bill format, the old translate command would raise an error.

Dependencies

N/A

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

make test

Is this change properly documented?

N/A

- fix(icbc): don't ignore the first transaction!

Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z Triple-Z requested review from gaocegege and a team as code owners September 18, 2024 16:11
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z Triple-Z changed the title WIP: feat(icbc): support icbc debit new bill format WIP feat(icbc): support icbc debit new bill format Sep 18, 2024
@Triple-Z Triple-Z changed the title WIP feat(icbc): support icbc debit new bill format [WIP] feat(icbc): support icbc debit new bill format Sep 18, 2024
@Triple-Z Triple-Z marked this pull request as draft September 18, 2024 16:37
@Triple-Z Triple-Z changed the title [WIP] feat(icbc): support icbc debit new bill format feat(icbc): support icbc debit new bill format Sep 18, 2024
Signed-off-by: TripleZ <me@triplez.cn>
@Triple-Z Triple-Z marked this pull request as ready for review September 22, 2024 10:00
@Triple-Z Triple-Z merged commit d28711b into master Sep 26, 2024
4 checks passed
@Triple-Z Triple-Z deleted the support-icbc-debit-new-format branch September 26, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants