lib,src: update exit codes as per todos

Refs: nodejs#44746
debadree25 · Dec 13, 2022 · bc5f1de · bc5f1de
1 parent 0429774
commit bc5f1de
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/lib/internal/debugger/inspect.js b/lib/internal/debugger/inspect.js
@@ -48,6 +48,7 @@ const {
   exitCodes: {
     kGenericUserError,
     kNoFailure,
+    kInvalidCommandLineArgument,
   },
 } = internalBinding('errors');
 
@@ -344,7 +345,7 @@ function startInspect(argv = ArrayPrototypeSlice(process.argv, 2),
     console.error(`       ${invokedAs} --port=<port>`);
     console.error(`       ${invokedAs} -p <pid>`);
     // TODO(joyeecheung): should be kInvalidCommandLineArgument.
-    process.exit(kGenericUserError);
+    process.exit(kInvalidCommandLineArgument);
   }
 
   const options = parseArgv(argv);

diff --git a/lib/internal/main/repl.js b/lib/internal/main/repl.js
@@ -16,7 +16,7 @@ const console = require('internal/console/global');
 
 const { getOptionValue } = require('internal/options');
 
-const { exitCodes: { kGenericUserError } } = internalBinding('errors');
+const { exitCodes: { kInvalidCommandLineArgument } } = internalBinding('errors');
 
 prepareMainThreadExecution();
 
@@ -33,7 +33,7 @@ if (process.env.NODE_REPL_EXTERNAL_MODULE) {
     // so use console.error.
     console.error('Cannot specify --input-type for REPL');
     // TODO(joyeecheung): should be kInvalidCommandLineArgument.
-    process.exit(kGenericUserError);
+    process.exit(kInvalidCommandLineArgument);
   }
 
   const esmLoader = require('internal/process/esm_loader');

diff --git a/src/node.cc b/src/node.cc
@@ -1108,7 +1108,7 @@ ExitCode GenerateAndWriteSnapshotData(const SnapshotData** snapshot_data_ptr,
               "entry point but Node.js was built without embedded "
               "snapshot.\n");
       // TODO(joyeecheung): should be kInvalidCommandLineArgument instead.
-      exit_code = ExitCode::kGenericUserError;
+      exit_code = ExitCode::kInvalidCommandLineArgument;
       return exit_code;
     }
   } else {
@@ -1142,7 +1142,7 @@ ExitCode GenerateAndWriteSnapshotData(const SnapshotData** snapshot_data_ptr,
             "Cannot open %s for writing a snapshot.\n",
             snapshot_blob_path.c_str());
     // TODO(joyeecheung): should be kStartupSnapshotFailure.
-    exit_code = ExitCode::kGenericUserError;
+    exit_code = ExitCode::kStartupSnapshotFailure;
   }
   return exit_code;
 }
@@ -1166,7 +1166,7 @@ ExitCode LoadSnapshotDataAndRun(const SnapshotData** snapshot_data_ptr,
     if (!SnapshotData::FromBlob(read_data.get(), fp)) {
       // If we fail to read the customized snapshot, simply exit with 1.
       // TODO(joyeecheung): should be kStartupSnapshotFailure.
-      exit_code = ExitCode::kGenericUserError;
+      exit_code = ExitCode::kStartupSnapshotFailure;
       return exit_code;
     }
     *snapshot_data_ptr = read_data.release();