forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fs: improve error performance of writevSync
PR-URL: nodejs#50038 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
- Loading branch information
1 parent
128aae4
commit d75f4f9
Showing
3 changed files
with
76 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const fs = require('fs'); | ||
const assert = require('assert'); | ||
const tmpdir = require('../../test/common/tmpdir'); | ||
tmpdir.refresh(); | ||
|
||
const path = tmpdir.resolve(`new-file-${process.pid}`); | ||
fs.writeFileSync(path, 'Some content.'); | ||
|
||
const bench = common.createBenchmark(main, { | ||
type: ['valid', 'invalid'], | ||
n: [1e5], | ||
}); | ||
|
||
const buffer = Buffer.from('Benchmark data.'); | ||
|
||
function main({ n, type }) { | ||
let fd; | ||
let result; | ||
|
||
switch (type) { | ||
case 'valid': | ||
fd = fs.openSync(path, 'r+'); | ||
|
||
bench.start(); | ||
for (let i = 0; i < n; i++) { | ||
result = fs.writevSync(fd, [buffer]); | ||
} | ||
|
||
bench.end(n); | ||
assert(result); | ||
fs.closeSync(fd); | ||
break; | ||
case 'invalid': { | ||
fd = 1 << 30; | ||
let hasError = false; | ||
bench.start(); | ||
for (let i = 0; i < n; i++) { | ||
try { | ||
result = fs.writevSync(fd, [buffer]); | ||
} catch { | ||
hasError = true; | ||
} | ||
} | ||
|
||
bench.end(n); | ||
assert(hasError); | ||
break; | ||
} | ||
default: | ||
throw new Error('Invalid type'); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters