Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-redis/issues/286 added test case demontrating that ZADD stores java string values properly. #291

Merged

Conversation

noahlz
Copy link

@noahlz noahlz commented Nov 2, 2021

The new test passes, just trying to reproduce issue on my side. Also, I cleaned up the tests a bit since the tests I added in a previous PR were under "custom serialization"

Test report:

[info] PipelineSpec:
[info] pipeline1
[info] - should do pipelined commands
[info] pipeline1 with publish
[info] - should do pipelined commands
[info] pipeline2
[info] - should do pipelined commands
[info] pipeline3
[info] - should handle errors properly in pipelined commands
[info] pipeline4
[info] - should discard pipelined commands
[info] - should publish without breaking the other commands in the pipeline
[info] pipeline no multi 1
[info] - should execute 100 lpushes in pipeline
[info] pipeline no multi 2
[info] - should do pipelined commands with an exception
[info] pipeline hyperloglog
[info] - should do pipelined commands
[info] hincrbyfloat inside a pipeline
[info] - should succeed with a correct response
[info] incrbyfloat inside a pipeline
[info] - should succeed with a correct response
[info] pipeline with batch submission 1
[info] - should execute all commands in batch
[info] pipeline with batch submission with custom serialization - 1
[info] - should execute all commands in batch
[info] pipeline with batch submission with custom serialization - 2
[info] - should execute all commands in batch
[info] pipeline with batch submission with custom serialization - 3
[info] - should execute all commands in batch
[info] pipelined with batch submission list operations
[info] - can pipeline zadd, followed by an expire, in batch
[info] - should handle values consisting of Kryo serialized string data
[info] - can pipeline zadd when the keys contain spaces, in batch
[info] - can pipeline zadd when the keys contain spaces, followed by an expire, in batch
[info] - can insert values in batch with zadd, and then later fetch them with zrange as they were inserted
[info] pipeline with batch submission for TTL (expire) commands
[info] - should accept setting simple key/value followed by an expiration, in batch
[info] - should accept pushing items on to a list followed by an expiration, in batch
[info] - should accept pushing binary data onto a list followed by an expiration, in batch
[info] Run completed in 4 seconds, 489 milliseconds.
[info] Total number of tests run: 23
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 23, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 14 s, completed Nov 2, 2021 9:44:25 AM

@debasishg debasishg merged commit 67d758f into debasishg:fix-format-batch Nov 2, 2021
debasishg added a commit that referenced this pull request Nov 2, 2021
* fixed bug in batched pipeline

* Fixed bug in batched pipeline to handle quotes within strings

* Added more test cases in PipelineSpec

* scala-redis/issues/286 added test case demontrating that ZADD stores java string values properly. (#291)

* Remove commented code

Co-authored-by: Noah Zucker <nzucker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants