Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8114 Implementing VariableScaleDecimal and improving tests #61

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

nrkljo
Copy link
Contributor

@nrkljo nrkljo commented Aug 6, 2024

Second attempt, depends on debezium/debezium#5743

@nrkljo nrkljo requested review from Naros and a team August 6, 2024 13:01
@nrkljo nrkljo marked this pull request as ready for review August 6, 2024 13:01
@nrkljo nrkljo force-pushed the DBZ-8114 branch 11 times, most recently from 227924a to e70b944 Compare August 13, 2024 06:44
Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see the tests green. Just one nit-pick I saw.

@@ -1,7 +1,7 @@

[![License](http://img.shields.io/:license-apache%202.0-brightgreen.svg)](http://www.apache.org/licenses/LICENSE-2.0.html)
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/io.debezium/debezium-connector-informix/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22io.debezium%22)
[![Build Status](https://github.com/debezium/debezium-connector-informix/actions/workflows/maven.yml/badge.svg?branch=main)](https://github.com/debezium/debezium-connector-informix/actions)
[![Build Status](https://github.com/debezium/debezium-connector-informix/actions/workflows/Maven%20CI/badge.svg?branch=main)](https://github.com/debezium/debezium-connector-informix/actions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this URL change is correct? The badge is rendered with a broken icon.

@jpechane jpechane merged commit 79df57b into debezium:main Aug 15, 2024
5 checks passed
@jpechane
Copy link
Collaborator

@nrkljo Applied, thanks! Could you please send a docs PR to the core and also a separate PR that addresses the broken link? In the latter case please feel free to merge yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants