This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
DBZ-7874 Separation of MariaDB dialect file #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome as a new contributor to Debezium, @joontube. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively. |
jpechane
reviewed
May 22, 2024
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.mariadb.jdbc</groupId> | ||
| <artifactId>mariadb-java-client</artifactId> | ||
| <version>3.4.0</version> |
There was a problem hiding this comment.
There should be no need for version here as the dependency is/should be defined at BOM lovel
There was a problem hiding this comment.
Oh, ok.
Is there anything else to do besides removing the version?
|
Superseded by #78 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-7874
If MariaDB, DatabaseDialectProvider loads MariaDbDatabaseDialect instead of MySqlDatabaseDialect