Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop integration of app icon #5

Closed
debloper opened this issue Jan 1, 2020 · 3 comments
Closed

Desktop integration of app icon #5

debloper opened this issue Jan 1, 2020 · 3 comments

Comments

@debloper
Copy link
Owner

debloper commented Jan 1, 2020

As of now with AppImage & electron-builder there's seems to be no reasonable way to make app icons work consistently across Linux DE. We are left with two choices:

  1. Ignore the icons not showing, focus on the app's core features & performances
  2. Use other distribution formats (traditional deb, rpm, pacman or newer snap, flatpak etc.)

At the moment, I'm personally against the idea of #2 because:

  • non-inclusivity: distro specific packages (deb, rpm, pacman etc.) aren't an exhaustive list
  • addon deps: newer packages require installing their package integration/manager tools (for AppImage that's optional)
  • fragmentation: setting up and maintaining multitple formats (for inclusivity) also leads to gradual fragmentation (as well as overheads, and possible feature imparity)

We can also debate the possibility of using a different packaging utility, but there isn't any good electron-builder alternative or a good way to

  • extract AppImage files
  • add necessary scripts to cache icons
  • repackage it back again

So, for now, we're stuck with these two tools, unless until something changes.


So, we're going ahead with Plan A:

Ignore the icons not showing, focus on the app's core features & performances.

A consolidated analysis to understand the issue with #1 (thanks @probonopd):
AppImageCommunity/appimaged#30

@debloper debloper closed this as completed Jan 1, 2020
debloper added a commit that referenced this issue Jan 1, 2020
@probonopd
Copy link

there's seems to be no reasonable way to make app icons work consistently across Linux DE

Can you describe in more detail what exactly is not working?

If the application sets the icon on the window, and if the desktop file uses the StartupWMClass field in the .desktop file correctly, then it should work sufficiently?

debloper added a commit that referenced this issue Jan 5, 2020
@debloper
Copy link
Owner Author

Can you describe in more detail what exactly is not working?

In our case, we're avoiding the use of @TheAssassin/AppImageLauncher (as mentioned).

With that in hand, the issues are:

  1. If SVG icon is used, .desktop file spec leaves it to DE devs' imagination how/whether they should work. Nothing to do with AppImage.
  2. If the app was opened by clicking, the hicolor PNG icons (even if all necessary resolutions exist) won't show up (the workarounds of caching the icons before launching the app is simply a overhead no one should have to go through)
  3. If the app was launched with CLI, there's a way to make it show the icon - but people who open apps with shell don't care about icons, and people who care about icons don't open apps with shell (in general).

Only thing I can request you to take care of is reducing the disconnect between 2 & 3. And of course, thanks for the awesome tool. Even with some limitations, it's still my favorite package distribution mechanism on *nix.

@probonopd
Copy link

Thanks @debloper. I agree that the current state is not ideal, but I am not sure what we could do from the AppImage side to improve things without the XDG specifications and/or desktop environments being changed. Please let me know if you have concrete ideas how to tackle the issues you've described. Thanks for using AppImage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants