Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed drawer toggles scrollbar #136

Closed
anfelor opened this issue Aug 4, 2016 · 7 comments
Closed

Fixed drawer toggles scrollbar #136

anfelor opened this issue Aug 4, 2016 · 7 comments
Assignees
@vipentti

Comments

@anfelor
Copy link

anfelor commented Aug 4, 2016 •
edited
Loading

  1. Go to https://debois.github.io/elm-mdl/#layout
  2. Enable Fixed drawer
  3. Click on "Card component" in the drawer
  4. Try to scroll :-)

Tested: Firefox and Chrome on Linux
@debois
Copy link
Owner

debois commented Aug 4, 2016

I can't reproduce this on Chrome, Firefox on Mac OS. Can you say a little bit more about what goes wrong? I'm not sure what you mean "toggles scrollbar"?

@OvermindDL1
Copy link
Contributor

I can reproduce it following his steps precisely, see attached image:
demo image
See when 'Card Component' is clicked then the scrollbars disappear in the menu view area on the far right.

@OvermindDL1
Copy link
Contributor

Chrome on windows 10.

@OvermindDL1
Copy link
Contributor

For note, I was trying the scrollwheel too, no movement on screen.

vipentti added a commit to vipentti/elm-mdl that referenced this issue Aug 6, 2016
@vipentti
Temporary fix for debois#136
af80b5c 
For some reason `toggleDrawer` toggles the scroll bar.
@vipentti vipentti mentioned this issue Aug 6, 2016
Merged
debois added a commit that referenced this issue Aug 6, 2016
@debois
Fix typos in Menu demo code
f798dd2 
Fix #136.
@debois
Copy link
Owner

debois commented Aug 6, 2016

Please ignore the above reference; should have been to #156.

debois pushed a commit that referenced this issue Aug 6, 2016
Merge pull request #155 from vipentti/bug-136
62a7626 
Temporary fix for #136
@debois debois removed the in progress label Aug 6, 2016
@debois
Copy link
Owner

debois commented Aug 6, 2016 •
edited
Loading

This is likely a logic arrow in Layout. @vipentti, I'd like to take over this unless you're already deep inside it?

@debois debois reopened this Aug 6, 2016
debois added a commit that referenced this issue Aug 6, 2016
@debois
Fix toggleDrawer disables scrolling on Layout with fixedHeader
d5e6056 
Changed line 825 now causes correct behaviour on unchanged line 870.

Fix #136.
@vipentti
Copy link
Collaborator

vipentti commented Aug 6, 2016

Feel free to take over

@debois debois closed this as completed Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vipentti vipentti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@debois @OvermindDL1 @vipentti @anfelor