Support for elm 0.18

[rosenk]

Elm 0.18 have just been released. When whoud we expect a support for it?

[danstn]

Playing with migration to 0.18.

elm-dom: debois/elm-dom#8
elm-parts: debois/elm-parts#13

What it would look like (would still need to update a bunch of things manually: Html, Json, etc)

[MichaelCombs28]

I got some time to get this done now, I'll start with elm-parts since we're using elm-mdl in production.

[danstn]

This is great news! Can't wait

[domenkozar]

@debois

[MichaelCombs28]

Already a pull request for elm-parts, just waiting on Debois

[danstn]

Yep, PRs for both elm-dom and elm-parts (see the refs above).

[domenkozar]

@MichaelCombs28 you can continue from danstn@1009e71 and make a PR that uses the elm-dom and elm-parts fork. We'll help you test once elm-mdl compile.

[MichaelCombs28]

I'm gonna spend a bit of time writing a test suite for elm-parts, something weird happened when trying to compile it after migrating, specifically it didn't recognize the Index alias. Maybe there's a possibility that List ints are no longer comparables.

Edit: Nevermind, just tested elm-parts, I'll get to elm-mdl asap!

[MichaelCombs28]

Finished the port and is ready for testing, working off https://github.com/MichaelCombs28/elm-mdl/tree/master
Maybe I should have made a new branch, but I wanted to finish fast so I forgot.

Also, please note that I'm using my forks as deps, but either way it's all done and should be ok to merge, if we don't get a response I'll publish mdl until Debois gets back to us.

[dpinn]

Michael, please do publish. I'd like to use your fork until it has been merged into debois/elm-mdl. Many thanks for your efforts.

[MichaelCombs28]

Done, just keep in mind I haven't ported the examples yet, the API is pretty much exactly the same, a few functions have changed & docs haven't been fully updated either but for the most part, any function named function' with the ' is now function_. http://package.elm-lang.org/packages/MichaelCombs28/elm-mdl/latest

[danstn]

Whoah! Great stuff 👍 Thanks heaps @MichaelCombs28 👊

[dpinn]

I don't want to be the bearer of bad news, but...

Problem in dependency MichaelCombs28/elm-mdl 1.0.0

The elm-package.json constraints of 'MichaelCombs28/elm-mdl' are probably
letting too much stuff through. Definitely open an issue on the relevant github
repo to get this fixed and save other people from this pain.

In the meantime, take a look through the direct dependencies of the broken
package and see if any of them have had releases recently. If you find the new
thing that is causing problems, you can artificially constrain things by adding
some extra constraints to your elm-package.json as a stopgap measure.

Does someone understand what that error message means?

[MichaelCombs28]

Strange I got it as well, it's only after you try to compile a project importing it. I'll deal with it in the morning.
Edit: I figured it out, it's installing an earlier version, tags got mixed up, it should only take bit to fix.

[MichaelCombs28]

Just fixed it, guess I got a little obsessed, but yeah all done give it a try.

[dpinn]

Yes, that seems to have done the trick. No more error message. Many thanks, Michael.

[nsb]

Somehow I still get the error message for elm-parts. Could it be an issue with my setup?

ERROR in ./src/elm/Main.elm
Module build failed: Error: Compiler process exited with error Compilation failed
Problem in dependency MichaelCombs28/elm-parts 1.0.0

The elm-package.json constraints of 'MichaelCombs28/elm-parts' are probably
letting too much stuff through. Definitely open an issue on the relevant github
repo to get this fixed and save other people from this pain

This is my elm dependencies

    "dependencies": {
        "MichaelCombs28/elm-mdl": "1.0.1 <= v < 2.0.0",
        "elm-lang/core": "5.0.0 <= v < 6.0.0",
        "elm-lang/html": "2.0.0 <= v < 3.0.0",
        "elm-lang/http": "1.0.0 <= v < 2.0.0",
        "elm-lang/navigation": "2.0.1 <= v < 3.0.0",
        "evancz/url-parser": "2.0.1 <= v < 3.0.0",
        "simonh1000/elm-jwt": "4.0.1 <= v < 5.0.0"
    },

[MichaelCombs28]

Can you show me your code? I'm not getting that error, even the examples are working now.

[nsb]

Yep, sorry. I found that I still need to update my code some more to work with 0.18. Somehow I didn't get those errors with my webpack setup only when manually running elm make. It's probably a problem with my code.

[MichaelCombs28]

For now, any issues should be opened on my fork until we can merge. https://github.com/MichaelCombs28/elm-mdl/issues

Thanks for everyone's feedback!

[CIB]

As described in this issue, it's currently not possible to use the new elm 0.18 history serialization feature with elm-mdl.

[MarkNijhof]

@MichaelCombs28 I saw this message in the reply to @CIB

I'm in the planning stages of building a Material Design library for Elm using the sortable table concepts and style.

I was wondering how close you plan to keep the API? I mean I am about to start a project and want to use MDL but if it is going to be abandoned and an upgrade to the "proper" way is going to be very hard then I don't know what is wise to do. What would you recommend? My Elm knowledge atm is not at a level that would make contributing useful I am afraid. I want to port our React app using Material-ui to Elm and MDL seems a perfect fit.

[MichaelCombs28]

Sorry for not responding sooner, but the elm-mdl project doesn't belong to me, I just needed to upgrade it to 0.18 for a project. There's a good chance that if Debois doesn't come back to it we'll keep fixing things since it is being used in production right now.

The rework of it is my personal project, so to make this clear, there is a high level of certainty that we will keep working on it. Issues should be posted onto my fork until the merge. I am only following this thread so if you have an issue, please post it on my fork.

[MarkNijhof]

Thanks! That sounds promising. Do you have a timeline in mind for the port to 0.18 as I would really like to start on that vs 0.17. I noticed for the demo to run there needs to be an update to the router component being used. If anything new pops up I'll post to your fork.

[MichaelCombs28]

The port is already finished

https://github.com/MichaelCombs28/elm-mdl

Edit: I just realized, you might be new to Elm. Search Elm Packages for elm-mdl and mine should be the only one as of now that's ported to 0.18

[MarkNijhof]

Yes, but not the demo application in there right? I am sorry if I wasn't clear. I think having that would help for documentation and help. Besides the router do you expect many changes in how to use MDL? I.e. How hard would the upgrade of the demo app be? I saw there is a pr for the router to put it on 0.18 if I can figure out how to use that then I will make a stab at upgrading the demo app.

…

On Wed, 30 Nov 2016 at 04:18, Michael Combs ***@***.***> wrote: The port is already finished https://github.com/MichaelCombs28/elm-mdl — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#253 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHThs-UD7CvUbpnTxo-zJlVrBEGiqB6ks5rDOsdgaJpZM4KxjOb> .

[MichaelCombs28]

The reason I haven't upgraded the Demo app is because of the changes to elm-navigation. The demo used a version of elm-route that relied on the old version of elm navigation. Other than that the api is pretty much the same, you must also account for the function that were used infix as before, I've changed them to account for composition in new Elm.

[debois]

Dear all,

I've been away for too long, apologies.

I'm in the process of upgrading to 0.18. The new version will feature (a) dropping the Parts library which seem to make so many people uncomfortable, and (b) multiple event dispatch courtesy of @vipentti. (I.e., if you want the focus event from a textfield, you can get it. Previously, you couldn't because the textfield needed it internally)

@MichaelCombs28: I tried to start off your fork, but you seem to have lost all @vipentti's work on multiple event dispatching, and it was very hard to merge with my draft no-parts variant, so much as I liked to, I couldn't start there. Appreciate you doing the fork!

@ALL: Apologies for the long absence.

[MarkNijhof]

Cool! Do you have a timeline in mind? I am currently rebuilding via the MDC css/js (also a great learning opportunity) as Google said they would not be continuing development on MDL have you any thoughts on that?

…

-Mark

On Mon, 26 Dec 2016 at 16:25, Søren Debois ***@***.***> wrote: Dear all, I've been away for too long, apologies. I'm in the process of upgrading to 0.18. The new version will feature (a) dropping the Parts library which seem to make so many people uncomfortable, and (b) multiple event dispatch courtesy of @vipentti <https://github.com/vipentti>. (I.e., if you want the focus event from a textfield, you can get it. Previously, you couldn't because the textfield needed it internally) @MichaelCombs28 <https://github.com/MichaelCombs28>: I tried to start off your fork, but you seem to have lost all @vipentti <https://github.com/vipentti>'s work on multiple event dispatching, and it was very hard to merge with my draft no-parts variant, so much as I liked to, I couldn't start there. Appreciate you doing the fork! @ALL <https://github.com/All>: Apologies for the long absence. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#253 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHThjkbVwq5lPrh33U82Fp5Bk505fAEks5rL9xngaJpZM4KxjOb> .

[MichaelCombs28]

Well if you need any help let me know! I've been on holiday for a few weeks and I'm back now as well so let us know the plan and we can help, this is possibly the most popular user created package outside of elm-community. Thank you so much for your efforts.

[debois]

@MichaelCombs28: Thanks, and you too! I'm good with the 0.18 release, I think, but in the short-term, elm-mdl really urgently need an autocomplete and a dropdown component; in the longer-term, we need to upgrade to Google MDL v2, which, if I'm understanding correctly, is actually the MDC that @MarkNijhof is referencing?

[hakonrossebo]

Would seem ok to close this issue now. Maybe create a new "roadmap" issue?

[cjduncana]

Sure, as long as the road map issue is referenced here.

[debois]

Makes sense.