Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Change of Menu Icon #61

Closed
saucewaffle opened this issue Jun 21, 2016 · 7 comments
Closed

Allow Change of Menu Icon #61

saucewaffle opened this issue Jun 21, 2016 · 7 comments

Comments

@saucewaffle
Copy link
Contributor

debois,

Needed to have multiple menus on a page so needed to be able to change what icon displays for them. Attached my version of Menu.elm with the changes, basically just imported Icon, setup an option and changed line 347 to set the Icon as whatever was sent in config.
Menu.elm.txt

Usage:
"
userMenu : Models.Model -> Html Messages.Msg
userMenu model =
div []
[
Menu.render MDL [0] model.mdl
[ Menu.bottomRight
, Menu.ripple
, Menu.icon "account_circle"
]
[ Menu.Item False True <| div [] [ text "My Profile" ]
, Menu.Item False True <| div [] [ text "Log In" ]
]

]
"

@debois
Copy link
Owner

debois commented Jun 21, 2016

Looks good! Could you submit a PR?

@saucewaffle
Copy link
Contributor Author

"It seems you do not have permission to push your changes to this
repository" :(

[image: Inline image 1]

On Tue, Jun 21, 2016 at 11:39 AM, Søren Debois notifications@github.com
wrote:

Looks good! Could you submit a PR?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#61 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ARnHiVdpFnAGusfxpw4uTmgZsRCSbfvHks5qOAXCgaJpZM4I61y-
.

@debois
Copy link
Owner

debois commented Jun 21, 2016

GitHub has a very neat way to do this, but you have to do it in a particular way. See the GitHub docs here.

saucewaffle added a commit to saucewaffle/elm-mdl that referenced this issue Jun 21, 2016
Added option to set menu icon
saucewaffle added a commit to saucewaffle/elm-mdl that referenced this issue Jun 21, 2016
Added option to set menu icon
@debois
Copy link
Owner

debois commented Jun 23, 2016

Do you have time to upgrade the .txt file to an actual PR?

@saucewaffle
Copy link
Contributor Author

Very sorry. I live in Cleveland and our team just won the basketball
championship. It's been crazy and I wasn't near a computer all day
yesterday. I'll have the PR to you today.

On Thu, Jun 23, 2016 at 6:31 AM, Søren Debois notifications@github.com
wrote:

Do you have time to upgrade the .txt file to an actual PR?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#61 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ARnHiRh2_sLqZMhWrR8LuGyDWdboGWvMks5qOmB7gaJpZM4I61y-
.

@debois
Copy link
Owner

debois commented Jun 23, 2016

Well, congratulations, then :)

I'll take a look at your PR.

@debois
Copy link
Owner

debois commented Jun 23, 2016

Closed by #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants