Fixes for recent ansible versions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `var|d()` pattern isn't working as intended. Have verified that changing the conditional commands to use the `is defined` is correctly evaluating the conditions.
The `split|last|first` pattern is no longer working in ansible-2.4.3. In any case the use of the `urlsplit()` filter is much more readable.
|
Hey, thanks for the PR! At the moment main development of the DebOps roles is done in the DebOps monorepo, would you consider posting your PRs to that repository instead? I didn't know about the Some of the fixes for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of fixes were needed to get this module working on recent ansible versions (at least 2.4.3).
First, a fix for conditional logic by removing
var|d()structures. Thevar|d()pattern isn't working as intended. Have verified that changing the conditional commands to use theis definedis correctlyevaluating the conditions.
Second, replace
split|last|firstwithurlsplit()filter as the pattern is no longer working in ansible-2.4.3. In any case the use of theurlsplit()filter is much more readable.