-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browser: Fixed that no logs output on IE8/9 #166
Conversation
IE 8/9 reports console methods as objects when using the typeof operator. https://web.archive.org/web/20111123190115/http://whattheheadsaid.com/2011/04/internet-explorer-9s-problematic-console-object Closes debug-js#148.
Maybe we just check for |
Sure, but |
Hmm, What you think about replacing |
... and Removing I think it is not necessary because that statement (below code / https://github.com/visionmedia/debug/blob/master/browser.js#L108) always returns Function.prototype.apply.call(console.log, console, arguments); So, I think that |
Yes, that's what I mentioned up above 😄 |
Let's not worry about the |
Agree 👍 I'll commit that changes :) |
Okay, I just committed that change, and tested on major web browsers. (IE8, IE9, IE10, IE11, Chrome Latest, Chrome Canary Latest, Firefox Latest, Safari Latest, Android 2.3.3, iOS 7, iOS 8, IE Mobile 11, etc...) |
browser: Fixed that no logs output on IE8/9
Thanks! |
You're welcome. Thank you! |
IE 8/9 reports console methods as objects when using the typeof operator.
https://web.archive.org/web/20111123190115/http://whattheheadsaid.com/2011/04/internet-explorer-9s-problematic-console-object
Closes #148.