Skip to content

Use same color for same namespace. #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Use same color for same namespace. #338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c7b678
Use same color for same namespace.
lchenay Nov 28, 2016
8e38722
Remove unused var.
lchenay Nov 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,20 @@ var prevTime;

/**
* Select a color.
*
* @param {String} namespace
* @return {Number}
* @api private
*/

function selectColor() {
return exports.colors[prevColor++ % exports.colors.length];
function selectColor(namespace) {
var hash = 0, i;

for (i in namespace) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this algorithm for somewhere that we need to give credit for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to find who to credit: https://www.google.com/search?q=%22Convert+to+32bit+integer%22

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://stackoverflow.com/a/7616484/376773

hash = ((hash << 5) - hash) + namespace.charCodeAt(i);
hash |= 0; // Convert to 32bit integer
}

return exports.colors[Math.abs(hash) % exports.colors.length];
}

/**
Expand Down Expand Up @@ -81,7 +88,7 @@ function debug(namespace) {

// add the `color` if not set
if (null == self.useColors) self.useColors = exports.useColors();
if (null == self.color && self.useColors) self.color = selectColor();
if (null == self.color && self.useColors) self.color = selectColor(namespace);

var args = new Array(arguments.length);
for (var i = 0; i < args.length; i++) {
Expand Down