Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DEBUG_FD #406

Merged
merged 2 commits into from
Dec 28, 2016
Merged

Remove DEBUG_FD #406

merged 2 commits into from
Dec 28, 2016

Conversation

TooTallNate
Copy link
Contributor

Now simply uses process.stderr. Breaking API change, for the v3 branch.

Previously used internal and undocumented Node.js APIs to support this underly used API.

Fixes #280.
Closes #386.

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386
@TooTallNate TooTallNate changed the title remove DEBUG_FD Remove DEBUG_FD Dec 28, 2016
@coveralls
Copy link

coveralls commented Dec 28, 2016

Coverage Status

Coverage increased (+11.0%) to 74.419% when pulling 67bf20a on remove/debug_fd into a741173 on v3.

@thebigredgeek thebigredgeek merged commit dade81d into v3 Dec 28, 2016
@thebigredgeek thebigredgeek deleted the remove/debug_fd branch December 28, 2016 00:25
thebigredgeek pushed a commit that referenced this pull request Apr 12, 2017
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
TooTallNate added a commit that referenced this pull request Aug 8, 2017
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
TooTallNate added a commit that referenced this pull request Aug 8, 2017
* remove DEBUG_FD

Now simply uses `process.stderr`. Breaking API change,
for the v3 branch.

Previously used internal and undocumented Node.js APIs to support
this underly used API.

Fixes #280
Closes #386

* remove DEBUG_FD from readme
@develar
Copy link

develar commented Aug 10, 2017

And how now we can change output without editing client code? What WebStorm or electron-webpack should do?

@tanyaYourchuck
Copy link

@thebigredgeek @TooTallNate DEBUG_FD was removed entirely?
why not leave it whitelisted to 1 or 2 as was decided as resolution of #410?

My project had also used DEBUG_FD to make sure debug goes to stdout in all submodules as @wallali mentioned: Modules I depend on who also internally use debug whose code I do not control keep outputting to stderr and I cannot redirect them to stdout.

I do not want to redirect all stderr to stdout, just want all debug output to go to stdout. Is this doable without the DEBUG_FD flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants