Check for undefined on browser globals.

[marbemac]

Not all environments include these globals. For example, web workers do not have global window objects.

This seems to be a regression from this commit: cae07b7

[coveralls]

Coverage remained the same at 63.804% when pulling 850749f on marbemac:master into 6bb07f7 on visionmedia:master.

[TooTallNate]

👍 I mentioned this in the PR, but I think it got merged before it was read.

[marbemac]

Ah yeah I see it there now. Yeah this little issue just bit us in the ass, because all sorts of dependencies use debug, and we're using some of them in web workers, which means they're throwing exceptions now :/.

[TooTallNate]

@marbemac could you remove the second check for the tests that you've updated? We don't need a truthiness test for window if we're already checking for typeof window !== 'undefined' right before that. Then I can merge + tag.

[marbemac]

I think part of the idea in that last commit was that the undefined check does not cover null. Without that second check, window.process will throw an exception if window is null.

[TooTallNate]

In my experience those values will ever be null.

Doesn't hurt to be defensive I guess, but the point of cae07b7 was to clean up these checks a bit.

[marbemac]

I'm happy to take it out! Shall I? Or leave it?

[TooTallNate]

Let's take them out please.

…

On Wed, May 17, 2017 at 19:05 Marc MacLeod ***@***.***> wrote: I'm happy to take it out! Shall I? Or leave it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#462 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEWWPX0LNu3tPxfIGaZsritOMTIdOyPks5r66dVgaJpZM4NemH_> .

[marbemac]

All set!

[coveralls]

Coverage remained the same at 63.804% when pulling 695ce4d on marbemac:master into 6bb07f7 on visionmedia:master.

[pmeijer]

👍

[pmeijer]

When will this be released?

[TooTallNate]

2.6.8 published