Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre release goodies #601

Merged
merged 9 commits into from
Sep 11, 2018
Merged

Pre release goodies #601

merged 9 commits into from
Sep 11, 2018

Conversation

Qix-
Copy link
Member

@Qix- Qix- commented Sep 11, 2018

Some cleanup before the new version is released (ref #598)

@coveralls
Copy link

coveralls commented Sep 11, 2018

Coverage Status

Coverage increased (+8.9%) to 83.111% when pulling c22c66c on pre-release-goodies into e43e5fe on master.

@Qix- Qix- self-assigned this Sep 11, 2018
@Qix- Qix- added change-patch This proposes or provides a change that requires a patch release change-minor This proposes or provides a change that requires a minor release labels Sep 11, 2018
@Qix- Qix- merged commit 9f4f8f5 into master Sep 11, 2018
@Qix- Qix- deleted the pre-release-goodies branch September 11, 2018 05:18
@ThomasGHenry
Copy link

ThomasGHenry commented Sep 11, 2018

I'm not yet sure why, but I think this broke React Native, FeathersJS, or both.

image


URL: http://10.0.2.2:8081/index.android.bundle?platform=android&dev=true&hot=false&minify=false

Body:
{"from":"/Users/thomasghenry/code/rn_apps/feathers_client/ptm_feathers/node_modules/debug/dist/debug.js","to":"./common","message":"Unable to resolve module `./common` from `/Users/thomasghenry/code/rn_apps/feathers_client/ptm_feathers/node_modules/debug/dist/debug.js`: Directory /Users/thomasghenry/code/rn_apps/feathers_client/ptm_feathers/node_modules/debug/dist/common doesn't exist","name":"UnableToResolveError","type":"UnableToResolveError","errors":[{}]}
onResponse
    DevServerHelper.java:332
execute
    RealCall.java:126
run
    NamedRunnable.java:32
runWorker
    ThreadPoolExecutor.java:1167
run
    ThreadPoolExecutor.java:641
run
    Thread.java:764

@Qix-
Copy link
Member Author

Qix- commented Sep 11, 2018

@ThomasGHenry please see #606 and provide information there so I can try to reproduce.

@debug-js debug-js locked as resolved and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
change-minor This proposes or provides a change that requires a minor release change-patch This proposes or provides a change that requires a patch release
Development

Successfully merging this pull request may close these issues.

3 participants