Fix browserify and supply alternative unpkg entry point #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qix-
commented
Sep 11, 2018
| @@ -11,7 +11,7 @@ dist: dist/debug.js dist/test.js | |||
| .INTERMEDIATE: dist/debug.es6.js | |||
| dist/debug.es6.js: src/*.js | |||
| @mkdir -p dist | |||
| browserify --standalone debug $< > $@ | |||
| browserify --standalone debug . > $@ | |||
There was a problem hiding this comment.
Reverted this to make sure browserify configurations in the future work as intended.
Qix-
added
the
change-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606.
Ref #603.
This restores Browserify functionality when
debugis used as a nested module. It also fixes the unpkg use case (though in reality there should be a better, more standard way to do this).However, it's the least intrusive way to fix both problems. I can't guarantee that the unpkg solution works, but users should be pinning versions anyway and not using
debug@*on live sites.cc @mjackson - if you have any input as to how to support unpkg in a less domain-specific way, that'd be great.