-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: refactor land into a seperate modules #86
Comments
Yeah, I've seen various problems with nodegit, e.g. #67. :-/ nodegit is used in |
There are thin-wrappers, such as |
Ooh, cool, thanks, I hadn't seen that. |
Would you mind if I give it a try (i.e. assign to me)? |
@refack sure, done. The previous code in 8c78da9 has the original code from before I switched Thanks! |
@refack FYI I just moved this project to the decaffeinate org, so the URL is different. I think everything should redirect just fine, but you may need/want to update your git remote. |
👍 |
@alangpierce can you review my current work. I got the |
@refack sorry for the delay! nodegit is still causing various issues, so I'm planning to move from it to simple-git based off of your branch. Your branch had a lot of changes, so I'm going to try to break it up into smaller pieces, first focusing on moving off of nodegit and then general Windows support should be a bit more manageable after that. |
Fixes #86 This also ended up simplifying the code quite a it, which is nice.
Fixes #86 This also ended up simplifying the code quite a it, which is nice.
nodegit
is a dependency monster (barly buildable on windows), and provides a very specific function, that's not nececerily a main use-case.The text was updated successfully, but these errors were encountered: