Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regexes are treated as identifiers #118

Closed
eventualbuddha opened this issue Dec 30, 2016 · 2 comments
Closed

Regexes are treated as identifiers #118

eventualbuddha opened this issue Dec 30, 2016 · 2 comments

Comments

@eventualbuddha
Copy link
Collaborator

(repl)

So far that's not an issue since they are just passed through in decaffeinate, but they should have their own node type.
@alangpierce
Copy link
Member

alangpierce commented Dec 30, 2016 •
edited
Loading

👍 I actually just noticed this when working on decaffeinate/decaffeinate#672. I need to do some text replacement within regexes but not identifiers, so getting this case in decaffeinate-parser working right is needed for that.

@eventualbuddha
Copy link
Collaborator Author

This was fixed by #120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eventualbuddha @alangpierce