fix: represent regular expressions as a Regex node
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Previously, regular expressions were represented as `Identifier` nodes, which hasn't been a problem for decaffeinate because all we wanted to do was pass them through anyway. Now, however, we want to do some processing on them and so need to identify them separately. Not to mention the fact that they are not identifiers!
eventualbuddha
force-pushed
the
regex
branch
from
d6cb2c6 to
ddabbca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Previously, regular expressions were represented as
Identifiernodes, which hasn't been a problem for decaffeinate because all we wanted to do was pass them through anyway. Now, however, we want to do some processing on them and so need to identify them separately. Not to mention the fact that they are not identifiers!