feat: add support for yield return
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward decaffeinate/decaffeinate#688
eventualbuddha
approved these changes
Jan 16, 2017
|
Heh, sure. Yeah, I guess at this point it shouldn't be so bad. :-) |
alangpierce
force-pushed
the
add-yield-return
branch
from
5e2b267 to
93ad71e
Compare
|
(I just updated the PR with mappers for |
eventualbuddha
approved these changes
Jan 17, 2017
| @@ -48,3 +54,29 @@ function mapMultiplyOp(context: ParseContext, node: CoffeeOp) { | |||
| mapAny(context, node.second) | |||
| ); | |||
| } | |||
|
|
|||
| function mapYieldOp(context: ParseContext, node: CoffeeOp) { | |||
There was a problem hiding this comment.
Missing return type.
There was a problem hiding this comment.
mapMultiplyOp was as well, and then I looked it up and learned that typescript can infer the type based on what's actually returned. But I guess you prefer to have explicit return types anyway? Would be nice if there was a tslint rule for that, although from a quick glance I don't see one.
| } | ||
| } | ||
|
|
||
| function mapYieldFromOp(context: ParseContext, node: CoffeeOp) { |
There was a problem hiding this comment.
Missing return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward decaffeinate/decaffeinate#688