feat: implement parsing for heregexes with interpolations #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward these issues: decaffeinate/decaffeinate#557 decaffeinate/decaffeinate#341 Just like with strings, we use decaffeinate-parser to unify the two styles of heregexes (ones with interpolations and ones without) into a single Heregex node type, and a normal heregexes simply have 0 interpolations. The CoffeeScript parser treats heregexes with interpolations as a call to the `RegExp` function with `+` operations for the components, so we can add a special case for that type of node and reuse the code for dealing with string interpolations. BREAKING CHANGE: Heregex expressions now always use the new Heregex node type rather than RegExp. In all cases, a Heregex node has an array of quasis and expressions.
eventualbuddha
approved these changes
Nov 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward these issues:
decaffeinate/decaffeinate#557
decaffeinate/decaffeinate#341
Just like with strings, we use decaffeinate-parser to unify the two styles of
heregexes (ones with interpolations and ones without) into a single Heregex node
type, and a normal heregexes simply have 0 interpolations. The CoffeeScript
parser treats heregexes with interpolations as a call to the
RegExpfunctionwith
+operations for the components, so we can add a special case for thattype of node and reuse the code for dealing with string interpolations.
BREAKING CHANGE: Heregex expressions now always use the new Heregex node type
rather than RegExp. In all cases, a Heregex node has an array of quasis and
expressions.