Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making edits after content is published #259

Closed
cassandraoid opened this issue Mar 3, 2017 · 7 comments
Closed

Making edits after content is published #259

cassandraoid opened this issue Mar 3, 2017 · 7 comments
Milestone

Comments

@cassandraoid
Copy link

- Bugish...

- What is the current behavior?

If you go back and edit a content piece it goes back to draft in your editorial workflow. There's no clear indication of what happens after you hit save, one might think it's already saved and ready.

- If the current behavior is a bug, please provide the steps to reproduce.

See above

- What is the expected behavior?

I'd like to see a card go to "Ready for review" after you've updated a previously published piece. More importantly, IMO, it should be different within the editorial workflow, a different color, highlight, or popping to the top - or a different column would all be helpful.'

In addition, if you're editing a piece that's already been published, but it's going back to the editorial workflow - it may be nice to have something that tells you that once you hit save.

@cassandraoid
Copy link
Author

Also, once you edit a published piece of content, it shouldn't take you back to the homepage of the content you were editing - it should take you to the editorial workflow.

@erquhart
Copy link
Contributor

erquhart commented Apr 3, 2017

For now let's just go with rerouting the user to the editorial workflow when saving a post.

@erquhart
Copy link
Contributor

Just reread this and noticed I missed some requirements. I now see three:

  • Indicate previously published posts - we now have the "New" indicator, so this is taken care of.
  • Move edited posts that were previously published to Waiting For Review instead of Draft.
  • Indicate to the user that the edited post is now in the editorial workflow - we can do this by simply navigating there on save.

@cassandraoid let me know if this sounds right.

@erquhart erquhart added this to the 1.0 milestone Jun 27, 2017
@verythorough
Copy link
Contributor

Routing the user to the editorial workflow on save may not be enough to communicate that the item is still waiting for review, especially if there's a large number of items in the workflow.

@erquhart
Copy link
Contributor

erquhart commented Jun 28, 2017

@verythorough true. I actually think the optimal answer is the contextual save button requested under #260 and depicted in #180, so expectation is inherently set.

@erquhart
Copy link
Contributor

Here's another, simpler approach: display publishing status for entries in the collection view.
Assigning a color code to the three publishing phases will help to improve clarity here.

The more I've considered this, the more I think we shouldn't put users in the workflow after saving a post. What if the user is editing multiple posts and doesn't want to change their review status?
For those that do, #260 is the right approach. Instead, the user should always be returned to the page they were on before editing the post.

@erquhart
Copy link
Contributor

erquhart commented Dec 7, 2017

As of 1.0 we no longer automatically transition you away from the editor when you save.

@erquhart erquhart closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants