Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a default publish_mode value #7102

Closed
privatemaker opened this issue Feb 14, 2024 Discussed in #7095 · 2 comments
Closed

Specifying a default publish_mode value #7102

privatemaker opened this issue Feb 14, 2024 Discussed in #7095 · 2 comments
Assignees

Comments

@privatemaker
Copy link
Contributor

Following and testing the Gitea support discussed in #6984, #6997 it seems now that Decap works on Gitea and the Forgejo fork when the server is configured correctly, which is very cool 🥳

However, while testing a couple sites, I noticed the following error when using the nifty Hugo Module hugomods/decap-cms made by @razonyang

Screenshot 2024-02-07 at 18-26-15 Editor

Upon inspecting the config.yml file the module generates, which is served as decap-cms-confg.yml it seems the module is injecting publish_mode: editorial_workflow even when it's not specified. However, since with gitea this is incompatible, I tried changing value to Boolean false which shows:

'publish_mode' must be string
'publish_mode' must be equal to one of the allowed values

Also when setting it as String values "false" or "default" or "normal" it still fails with this error:

'publish_mode' must be equal to one of the allowed values

@razonyang modified his module to accept publish_mode: '' to omit the key being injected which solves this, for now. But I think Decap should also have a default value for this field.

Originally discussed in #7095

hip3r added a commit to poslovnimediji/decap-cms that referenced this issue Feb 22, 2024
hip3r added a commit to hip3r/decap-website that referenced this issue Feb 22, 2024
privatemaker pushed a commit to decaporg/decap-website that referenced this issue Feb 27, 2024
demshy pushed a commit that referenced this issue Mar 1, 2024
* //issues/7102 publish mode allow empty string

* fix: //issues/7125 bump vfile version
@martinjagodic
Copy link
Member

@hip3r I se you did some work here, is this done?

@hip3r
Copy link
Contributor

hip3r commented Aug 2, 2024

pr #7116

martinjagodic pushed a commit to decaporg/decap-website that referenced this issue Oct 7, 2024
* /decaporg/decap-cms/issues/7102 documentation for publish mode possible values

* fix: /decaporg/decap-cms/issues/6797 registerEditorComponent example
martinjagodic pushed a commit to decaporg/decap-website that referenced this issue Oct 17, 2024
* /decaporg/decap-cms/issues/7102 documentation for publish mode possible values

* /decaporg/decap-cms/issues/7223 update custom mounting docs

* pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants