Slate Editor Crashing semi randomly

[DavidWells]

Describe the bug

Slate editor crashes randomly with Error: Cannot resolve a DOM node from Slate node: {"text":""}

I've managed to track this down and reproduce it on https://demo.decapcms.org/#/collections/posts/entries/2024-03-20-post-number-20

To Reproduce

1. Go to editor https://demo.decapcms.org/#/collections/posts/entries/2024-03-20-post-number-20
2. In the body editor hit Shift + return and shift + return again, then they and delete that line
3. Editor crashes

editor.crashing.mp4

Expected behavior
No crashes

Related

This was the only reference I could find for this error ianstormtaylor/slate#3930 but I'm unclear on how to resolve.

[DavidWells]

Maybe it's the <br> tag that is being inserted via

decap-cms/packages/decap-cms-widget-markdown/src/MarkdownControl/renderers.js

Lines 207 to 209 in 6266ccc

	function Break(props) {
	return <br {...props.attributes} />;
	}

with no children as described in ianstormtaylor/slate#3930

Might need to do something like

function Break(props) {
  return <><br {...props.attributes} />{props.children}</>;
}

[DavidWells]

I tested it out by changing br to a div that gets the children. It seemed to worked (no more editor crash)

div.as.br.tag.mp4

I think all the components in https://github.com/decaporg/decap-cms/blob/6266ccc16a8a992695d4bdf13a63746986cedc3e/packages/decap-cms-widget-markdown/src/MarkdownControl/renderers.js might need to render out {props.children} for slate to not throw when nodes get deleted.

[demshy]

In 3.2.1 the lose of focus after backspacing from multiple shift+return's should also be fixed, do you mind testing again?