-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/configinlink #1146
Merged
Merged
Feat/configinlink #1146
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4979c64
fix: allows for valid config types expansion
brianlmacdonald 05348f6
feat: config url can now come through link tag
brianlmacdonald 7d9906b
fix: lints added coded
brianlmacdonald adcc171
fix: slims down code per review
brianlmacdonald 6ec83cd
fix: expands query to find supported type
brianlmacdonald e44c79f
fix: removes typo in test copy
brianlmacdonald d118c54
fix: changes validTypes to object
brianlmacdonald 5c1cfb3
fix: groups config functions into one getConfig func
brianlmacdonald 68518fa
adds console message for config url
brianlmacdonald a888f39
adds to docs
brianlmacdonald 9d4a8a1
update docs
erquhart 681f98d
fix test
erquhart 4d2d3a9
fix merge conflicts
tech4him1 3d7bd0b
avoids empty path with link without href. changes link console message
brianlmacdonald c75061d
removes additional console
brianlmacdonald c738a82
fixes link path in console
brianlmacdonald 6348f0c
fix: remove superfluous .allcontributorsrc change
Benaiah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Brian, missed the configUrl value here. I will let you decide how to manage it 😄
With it fixed, things look good after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@talves done and done!