Prevent Git Gateway users with invalid tokens from logging in. #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This often happens when a user changes a repo from public to private, so we want to make that specific case very clear.
|
Deploy preview for netlify-cms-www ready! Built with commit 6e50b95 |
|
Deploy preview for cms-demo ready! Built with commit 6e50b95 |
|
@erquhart This is ready to review/merge if you want it in the release. |
brianlmacdonald
pushed a commit
to brianlmacdonald/netlify-cms
that referenced
this pull request
May 23, 2018
…org#1209) * Prevent Git Gateway users without permission from login. * Handle Git Gateway token expiry explicitly. This often happens when a user changes a repo from public to private, so we want to make that specific case very clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #647. Also addresses the case where a user changes their GH repo from public to private after Git Gateway is set up.
- Test plan
Manually tested.
- Description for the changelog
Prevent Git Gateway users with invalid tokens from logging in.
- A picture of a cute animal (not mandatory but encouraged)