Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab backport to v1 #1421

Closed
wants to merge 43 commits into from
Closed

Conversation

Benaiah
Copy link
Contributor

@Benaiah Benaiah commented Jun 10, 2018

Backport of #1343 onto the v1 branch.

Benaiah and others added 30 commits June 8, 2018 15:22
them.

This is not optimal, but it is how the GitHub implementation works and
should be fixed later.
`hasWriteAccess` was not working in the case where permissions were
granted on a single group-owned repo, instead of the entire group.
@verythorough
Copy link
Contributor

verythorough commented Jun 10, 2018

Deploy preview for netlify-cms-www ready!

Built with commit fe8eed8

https://deploy-preview-1421--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

verythorough commented Jun 10, 2018

Deploy preview for cms-demo ready!

Built with commit fe8eed8

https://deploy-preview-1421--cms-demo.netlify.com

Copy link
Contributor

@tech4him1 tech4him1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to make sure this is fully updated to the main GitLab PR before merge.

@erquhart
Copy link
Contributor

Backported manually.

@erquhart erquhart closed this Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants