-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab backport to v1 #1421
Closed
Closed
Gitlab backport to v1 #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
them. This is not optimal, but it is how the GitHub implementation works and should be fixed later.
`hasWriteAccess` was not working in the case where permissions were granted on a single group-owned repo, instead of the entire group.
Deploy preview for netlify-cms-www ready! Built with commit fe8eed8 |
Deploy preview for cms-demo ready! Built with commit fe8eed8 |
tech4him1
suggested changes
Jun 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to make sure this is fully updated to the main GitLab PR before merge.
Benaiah
force-pushed
the
gitlab-backport-to-v1
branch
from
June 12, 2018 00:43
9ac9f48
to
fe8eed8
Compare
Backported manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1343 onto the
v1
branch.